Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate AOE codes #15918

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Remove duplicate AOE codes #15918

merged 3 commits into from
Sep 19, 2024

Conversation

lucero-v
Copy link
Collaborator

This PR removes duplicate AOE codes from observation-mapping table

Changes

  • Removed the following codes: 30525-0, 95418-0, 95421-4, 95419-8, 95420-6, 77974-4, 95417-2

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

  • update table in staging and prod

@lucero-v lucero-v requested a review from a team as a code owner September 18, 2024 21:22
@lucero-v lucero-v self-assigned this Sep 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@lucero-v lucero-v added the onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS. label Sep 18, 2024
@lucero-v lucero-v enabled auto-merge (squash) September 18, 2024 21:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Test Results

1 229 tests  ±0   1 225 ✅ ±0   7m 30s ⏱️ -9s
  161 suites ±0       4 💤 ±0 
  161 files   ±0       0 ❌ ±0 

Results for commit 0e225cc. ± Comparison against base commit 8b5742d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Integration Test Results

 53 files   53 suites   27m 45s ⏱️
410 tests 401 ✅ 9 💤 0 ❌
413 runs  404 ✅ 9 💤 0 ❌

Results for commit 0e225cc.

♻️ This comment has been updated with latest results.

@lucero-v lucero-v merged commit 694f677 into master Sep 19, 2024
20 of 21 checks passed
@lucero-v lucero-v deleted the engagement/lucero/remove-duplicate-aoes branch September 19, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-chaparro victor-chaparro victor-chaparro approved these changes

@oslynn oslynn Awaiting requested review from oslynn

@GilmoreA6 GilmoreA6 Awaiting requested review from GilmoreA6

@abiphilipnava abiphilipnava Awaiting requested review from abiphilipnava

@JessicaWNava JessicaWNava Awaiting requested review from JessicaWNava

Assignees

@lucero-v lucero-v

Labels
onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucero-v @victor-chaparro